Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(developer): Mention PHP 8.4 support #12292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(developer): Mention PHP 8.4 support #12292

wants to merge 1 commit into from
+62 −2

Conversation

nickvergessen
Copy link
Member

grafik

@nickvergessen nickvergessen self-assigned this Oct 17, 2024
@nickvergessen nickvergessen added this to the Nextcloud 31 milestone Oct 17, 2024
@nickvergessen
Copy link
Member Author

/backport to stable30

come-nc
come-nc reviewed Oct 17, 2024
View reviewed changes
developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_30.rst

<dependencies>
<php min-version="8.1" max-version="8.4" />
<nextcloud min-version="26" max-version="28" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<nextcloud min-version="26" max-version="28" />
<nextcloud min-version="26" max-version="30" />

Makes no sense to support 8.4 but not 30.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, was copy pasta from adding 8.3 and seems I didnt replace all.

Suggested change
<nextcloud min-version="26" max-version="28" />
<nextcloud min-version="28" max-version="30" />

come-nc
come-nc reviewed Oct 17, 2024
View reviewed changes
developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_31.rst

<dependencies>
<php min-version="8.1" max-version="8.4" />
<nextcloud min-version="26" max-version="28" />
Copy link
Contributor

@come-nc come-nc Oct 17, 2024 •
edited by nickvergessen
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<nextcloud min-version="26" max-version="28" />
<nextcloud min-version="29" max-version="31" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@nickvergessen nickvergessen

Labels
3. to review backport-request enhancement manual: developer
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @come-nc